feat(onnx): only show gpu selection on dml runner #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the UI clarity for ONNX execution provider settings by conditionally displaying GPU selection options only when the DirectML runner is selected, since GPU selection is only relevant for that specific runner.
Key Changes:
- Conditionally display GPU selection UI based on selected ONNX runner
- Add CPU fallback execution provider for improved robustness
- Fix Android compatibility by returning a default GpuInfo object instead of an empty list
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| OpenUtau/Views/PreferencesDialog.axaml | Wraps GPU selection UI elements in a StackPanel with conditional visibility binding |
| OpenUtau/ViewModels/PreferencesViewModel.cs | Adds ShowOnnxGpu property and toggle logic to control GPU options visibility based on DirectML runner selection |
| OpenUtau.Core/Util/Onnx.cs | Returns default GpuInfo for Android instead of empty list and adds CPU execution provider fallback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this modification, the GPU selection shows up in every runners, which makes it confusing since the GPU selection result is only used in DirectML runner. After this, the relationship becomes clear, as shown in the screen record below:
2025-12-02.22-59-06.mp4