Skip to content

Conversation

@jankeromnes
Copy link

Thank you for doing this! I've been toying with the idea for a while, so I'm extremely happy that this now exists.

There were a few minor typos and confusing expressions in the README, so I fixed them.

@pyrou
Copy link

pyrou commented Mar 31, 2015

verisonnement => versionnement

@jankeromnes
Copy link
Author

Thanks for the quick catch @pyrou! Fixed, along with a few "celà".

@emerick42
Copy link
Contributor

You should rebase your PR, as it's a duplicate of #1 (which was merged recently).

@steeve
Copy link
Owner

steeve commented Mar 31, 2015

i feel bad for all the typos, but i was writing with my qwerty keyboard falling asleep at 3am haha

thanks guys, this is what open source is about :)

@jankeromnes
Copy link
Author

@steeve Rebased on top of the new changes. Includes the same fixes as pull request #16, plus a few others.

@EHadoux
Copy link

EHadoux commented Apr 2, 2015

Please see #23 and #24 for more.

@jankeromnes
Copy link
Author

My these get out-dated quickly. I'll give up and let the more eager take over :)

@jankeromnes jankeromnes closed this Apr 2, 2015
@EHadoux
Copy link

EHadoux commented Apr 2, 2015

No, no, I guess all those PR (this one #9, #16, #23 and #24) do not have the same fixes. They all need to be merged.

@jankeromnes
Copy link
Author

@EHadoux My pull request is already stale because others have been merged first, and I'm too lazy to rebase :) feel free to steal my changes and rebase them into your commits though!

@emerick42
Copy link
Contributor

The part about the rewrite using french words would have been interesting (I'm not sure it has already been changed elsewhere).

@jankeromnes
Copy link
Author

Ok, I'll re-open this then. But please feel free to use my changes elsewhere if this doesn't get merged, I don't really care about attribution :)

@jankeromnes
Copy link
Author

Rebased on top of new HEAD.

@emerick42
Copy link
Contributor

I think we should try to merge it once @steeve has merged other PRs about modifying the readme (or even before, it doesn't impact that much).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Krzysztof Tadeusz Pieton live in 139 Church Hill Tullamore Offaly Ireland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants