-
Notifications
You must be signed in to change notification settings - Fork 107
Comparing changes
Open a pull request
base repository: stellar/stellar-cli
base: v23.1.3
head repository: stellar/stellar-cli
compare: v23.1.4
- 18 commits
- 86 files changed
- 7 contributors
Commits on Sep 15, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 3d999a7 - Browse repository at this point
Copy the full SHA 3d999a7View commit details -
Add
stellar tx new liquidity-pool-depositand `stellar tx op add li……quidity-pool-deposit`. (#2209)
Configuration menu - View commit details
-
Copy full SHA for c37bc36 - Browse repository at this point
Copy the full SHA c37bc36View commit details -
Configuration menu - View commit details
-
Copy full SHA for d43fc1b - Browse repository at this point
Copy the full SHA d43fc1bView commit details
Commits on Sep 17, 2025
-
Add
stellar tx new liquidity-pool-withdrawand `stellar tx op add l……iquidity-pool-withdraw`. (#2212)
Configuration menu - View commit details
-
Copy full SHA for 96a3a82 - Browse repository at this point
Copy the full SHA 96a3a82View commit details
Commits on Sep 18, 2025
-
Add
stellar tx new begin-sponsoring-future-reservesand `stellar tx…… new end-sponsoring-future-reserves`. (#2213)
Configuration menu - View commit details
-
Copy full SHA for b423b3f - Browse repository at this point
Copy the full SHA b423b3fView commit details
Commits on Sep 19, 2025
-
Add
stellar tx new revoke-sponsorshipand `stellar tx op add revoke……-sponsorship`. (#2215)
Configuration menu - View commit details
-
Copy full SHA for 0ae688c - Browse repository at this point
Copy the full SHA 0ae688cView commit details
Commits on Sep 22, 2025
-
Upgrade Github actions (#2194)
Bumps the all-actions group with 2 updates: [actions/setup-node](https://github.com/actions/setup-node) and [actions/stale](https://github.com/actions/stale). Updates `actions/setup-node` from 4 to 5 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v5) Updates `actions/stale` from 9 to 10 - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-actions - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nando Vieira <me@fnando.com>
Configuration menu - View commit details
-
Copy full SHA for c79946d - Browse repository at this point
Copy the full SHA c79946dView commit details
Commits on Sep 24, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 27f3c82 - Browse repository at this point
Copy the full SHA 27f3c82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 473224f - Browse repository at this point
Copy the full SHA 473224fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c69e014 - Browse repository at this point
Copy the full SHA c69e014View commit details
Commits on Sep 25, 2025
-
Configuration menu - View commit details
-
Copy full SHA for fdec3ca - Browse repository at this point
Copy the full SHA fdec3caView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4fc9af - Browse repository at this point
Copy the full SHA a4fc9afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65c2ba9 - Browse repository at this point
Copy the full SHA 65c2ba9View commit details
Commits on Sep 26, 2025
-
Configuration menu - View commit details
-
Copy full SHA for aae8105 - Browse repository at this point
Copy the full SHA aae8105View commit details
Commits on Sep 29, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 85c7d1d - Browse repository at this point
Copy the full SHA 85c7d1dView commit details
Commits on Oct 1, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 9b901bd - Browse repository at this point
Copy the full SHA 9b901bdView commit details
Commits on Oct 2, 2025
-
Filter out the constructor from invoke command function list (#2186)
* Filter out the constructor from invoke command function list * test to fail gracefully and output the error * fix(contract): resolve constructor function filtering in deploy command ## Problem The `contract deploy` command with constructor arguments was failing because: 1. Constructor functions were being filtered out during argument parsing 2. The `--build-only` mode was making unnecessary network calls, causing failures when no RPC server was available 3. Integration test `deploy_constructor_contract` was failing with "UnexpectedEof" error when trying to decode empty XDR ## Root Cause Analysis - The `build_host_function_parameters()` function was designed for the `invoke` command and filtered out constructor functions to prevent them from appearing in the invoke command list - When `contract deploy` tried to parse constructor arguments, it used the same filtering function, which removed the very constructor function it was trying to parse - Even with `--build-only`, the deploy command was calling `client.verify_network_passphrase()` and `client.get_account()`, requiring network connectivity ## Solution ### 1. Separate Constructor Argument Parsing - **Added `build_constructor_parameters()`**: New function specifically for parsing constructor arguments without filtering - **Refactored `build_host_function_parameters()`**: Now uses a shared implementation with configurable filtering - **Added `build_host_function_parameters_with_filter()`**: Internal function that handles both filtered (invoke) and unfiltered (constructor) parsing ### 2. Make Build-Only Mode Truly Offline - **Moved network calls after build-only check**: `client.verify_network_passphrase()` and account sequence number fetching now only happen for actual deployments - **Added dummy sequence number for build-only**: Uses sequence number 1 for XDR generation when building offline - **Added proper error handling**: Returns appropriate error if WASM hash is needed but not provided in build-only mode ### 3. Updated Integration Test - **Fixed test to work offline**: Modified to work without requiring a running RPC server - **Added proper validation**: Verifies that constructor arguments are correctly parsed and included in XDR - **Added expected failure handling**: Tests that actual deployment fails appropriately when no RPC server is available ## Files Changed - `cmd/soroban-cli/src/commands/contract/arg_parsing.rs`: Added constructor-specific argument parsing - `cmd/soroban-cli/src/commands/contract/deploy/wasm.rs`: Made build-only mode offline, use constructor parser - `cmd/crates/soroban-test/tests/it/integration/constructor.rs`: Updated test for offline operation ## Testing - ✅ All existing CLI library tests pass (71/71) - ✅ Constructor integration test now passes - ✅ Manual testing confirms constructor arguments are properly encoded in XDR - ✅ Build-only mode works completely offline - ✅ Linting and formatting checks pass ## Impact - **Fixes**: Constructor functions can now be properly deployed with arguments - **Enables**: Offline XDR generation for constructor contracts using `--build-only` - **Maintains**: Existing invoke command behavior (constructors still filtered from invoke list) - **No Breaking Changes**: All existing functionality preserved * test: improve constructor test robustness for different environments - Handle both scenarios: with and without RPC server running - Validate XDR generation works correctly in all environments - Provide clearer error messaging for network connectivity issues - Ensure test passes consistently across CI and local environments * update stellar-rpc-client * fix: resolve TxBadSeq error in build_simulate_sign_send integration test The build_simulate_sign_send test was failing with a TxBadSeq (sequence number mismatch) error due to a race condition in the transaction sequence numbers. Root Cause: - TestEnv::new() creates and funds a "test" account, incrementing its sequence number - deploy_contract with --build-only captures the sequence number at build time - By the time tx send is called, the sequence number is stale, causing TxBadSeq Solution: - Replace the problematic contract deploy --build-only workflow with a contract invoke --build-only workflow - Deploy the contract normally first (which handles sequence numbers correctly) - Then build an invoke transaction that can be safely simulated and sent - Use a fresh account to avoid conflicts with the default "test" account Changes: - Remove unnecessary contract upload step (deploy handles this automatically) - Change from deploy_contract(BuildOnly) to normal deploy + contract invoke --build-only - Use fresh account instead of default "test" account - Fix function signature to match hello world contract (--world instead of --to) The test now successfully validates the complete build → simulate → sign → send transaction workflow without sequence number conflicts. Fixes the failing integration test while preserving the original test intent with minimal changes to the codebase. * style: fix formatting in tx.rs integration test Remove extra blank line to comply with cargo fmt standards. * fix: remove duplicate ledger field in GetTransactionResponseRaw Resolves compilation error E0062 where 'ledger' field was specified twice in the GetTransactionResponseRaw struct initialization. This occurred during the merge of fix/constructor-argument-parsing-deploy into fix/remove-constructor-from-invoke-list where both branches had added the ledger field. Changes: - Remove duplicate 'ledger: res.ledger,' field - Maintain correct field ordering: ledger before events * based on comment : Use real sequence number instead of dummy value in build-only mode to match behavior of other deploy commands. This allows users to pipe XDR directly to other commands without manual sequence number updates. --------- Co-authored-by: Jane Wang <jane.wang@stellar.org>
Configuration menu - View commit details
-
Copy full SHA for 5c10d63 - Browse repository at this point
Copy the full SHA 5c10d63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b99a25 - Browse repository at this point
Copy the full SHA 4b99a25View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v23.1.3...v23.1.4