Skip to content

Add support for identities as signer on tx new set-options. #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2025
Merged

Add support for identities as signer on tx new set-options. #2216

merged 2 commits into from
Sep 24, 2025

Conversation

@fnando
Copy link
Member

@fnando fnando commented Sep 19, 2025

What

# before
$ stellar tx new set-options --signer sponsor --signer-weight=20
error: invalid value 'sponsor' for '--signer <SIGNER>': xdr value invalid

# after
$ stellar tx new set-options --signer sponsor --signer-weight=20 --build-only
AAAAAgAAAACkBZuRlmsx0id9DepMyDU50OLurzdOysfTio7sxz6HzwAAAGQAANJ2AAAAAwAAAAAAAAAAAAAAAQAAAAAAAAAFAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAAAAAIogPEBhv4JY/n4BwiL6KsNVbNk/LyVwhverKE31ymPPAAAAFAAAAAAAAAAA

Why

Fix #2214.

Known limitations

N/A

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Sep 19, 2025
@fnando fnando moved this from Backlog (Not Ready) to Needs Review in DevX Sep 19, 2025
@fnando fnando self-assigned this Sep 19, 2025
@fnando fnando enabled auto-merge (squash) September 19, 2025 17:28
@fnando fnando merged commit 27f3c82 into main Sep 24, 2025
30 of 31 checks passed
@fnando fnando deleted the tx-new-set-options-signer branch September 24, 2025 04:12
@github-project-automation github-project-automation bot moved this from Needs Review to Done in DevX Sep 24, 2025
@BrewTestBot BrewTestBot mentioned this pull request Oct 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

@elizabethengelman elizabethengelman Awaiting requested review from elizabethengelman

Assignees

@fnando fnando

Labels

None yet

Projects

DevX
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stellar tx new set-options --signer SIGNER should accept an identity

3 participants

@fnando @leighmcculloch