Embed examples contract list into source and remove from build script #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Embed examples contract list into source and remove from build script.
Why
When running a lot of builds repeatedly, such as in CI, we're hitting GitHub rate limits on almost every build. It's convenient that the list is auto updated at every build, but we don't really need it to be updated that frequently. We'll get 90% of the same benefit with a reminder that it's got out of sync to update it from time to time with a command.
The added check will run once a commit, but won't block builds if we do rate limit or if it's out of date. Folks can run the generate make target as needed to get the check back to green.
This also means that cargo installing the crate will no longer phone out to GitHub and potentially get blocked too.