fix(ts-bindings): package.json needs type: module #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we started using `module: nodenext` in tsconfig.json, we need to tell libraries that import these ones that the exported code is an ES Module. This fixes github.com/stellar/soroban-astro-template to work with libraries generated with `soroban contract bindings typescript`
a6b35b2 to
ac46671
Compare
BlaineHeffron
approved these changes
May 20, 2024
kalepail
approved these changes
May 21, 2024
elizabethengelman
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Since we started using
module: nodenextin tsconfig.json, we need totell libraries that import these ones that the exported code is an ES
Module.
Why
This fixes github.com/stellar/soroban-astro-template to work with
libraries generated with
soroban contract bindings typescriptKnown limitations
N/A