contract build: fix when used in sub-directories of crates #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
commented
Jul 15, 2024
leighmcculloch
commented
Jul 15, 2024
graydon
requested changes
Jul 15, 2024
graydon
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change contract build behavior when executed in the sub-directory of a workspace that contains a crate of that workspace. Make it build only that crate instead of the entire workspace.
Why
The current behavior is to build the entire workspace.
The behavior of cargo build is to build only the crate of the sub-directory.
This command is designed to immitate cargo build, and differences in behavior are surprising and unexpected.
This change is a breaking change, but it is fixing a bug.
Close #1450