Skip to content

Feat/ledger latest #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 19, 2025
Merged

Feat/ledger latest #2046

merged 12 commits into from
Jun 19, 2025

Conversation

@elizabethengelman
Copy link
Collaborator

@elizabethengelman elizabethengelman commented Jun 12, 2025 •
edited
Loading

What

Add a stellar ledger latest command to get the latest ledger for the given network. Defaults to testnet.

It also defaults to the text output, which looks like this:

stellar ledger latest

Sequence: 1468935
Protocol Version: 22
ID: 41a18d68e814201db155ee754c1f4523f899dc31a234cb1d6435030d97ddb94f

--output json and --output json-formatted are also available.

Why

To allow for users to easily look up that latest ledger from the CLI.

Known limitations

N/A

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Jun 12, 2025
@elizabethengelman elizabethengelman marked this pull request as ready for review June 12, 2025 19:32
leighmcculloch
leighmcculloch reviewed Jun 13, 2025
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question inline.

leighmcculloch
leighmcculloch reviewed Jun 17, 2025
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small requests inline.

elizabethengelman and others added 2 commits June 17, 2025 17:29
@elizabethengelman @leighmcculloch
Apply suggestions from code review
0d3f838 
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@elizabethengelman
Add missing doc comment
fb396ea
leighmcculloch
leighmcculloch approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks suggested, otherwise looks great 👍🏻

@elizabethengelman @leighmcculloch
Update cmd/crates/soroban-test/tests/it/integration/ledger.rs
9f49ab8 
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@elizabethengelman elizabethengelman enabled auto-merge (squash) June 18, 2025 18:15
elizabethengelman and others added 2 commits June 19, 2025 10:08
@elizabethengelman @leighmcculloch
Update cmd/soroban-cli/src/commands/ledger/mod.rs
d973a1b 
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@elizabethengelman
Update generated docs
0dd44f1
@elizabethengelman elizabethengelman merged commit ab08bc1 into main Jun 19, 2025
35 checks passed
@elizabethengelman elizabethengelman deleted the feat/ledger-latest branch June 19, 2025 15:15
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

DevX
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elizabethengelman @leighmcculloch