Feat/only fee #2040
Merged
Feat/only fee #2040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make envelope the default fetch when no subcommand is given In order to flatten an optional field, I needed to remove the group(skip) on network::Args. But this lead to a conflict because there are multiple groups with an implicit name of 'Args' that were all trying to be flattened. The solution to this was add a specific group id to network::Args. * Make envelope the default fetch when no subcommand is given * Refactor to use args impl * Clean up
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
e9e1369 to
bb3f216
Compare
|
I was able to test out fetching a failed soroban tx, and here was the result:
The way I was able to test a failed tx was to create a fn in the contract that was time based - so after a certain timestamp it would panic. And then I simulated the tx with a "passing" timestamp, and then sent it with a failing timestamp. Not sure if there is an easier way to reproduce this scenario, I was running into txns failing during simulation and therefore not making it to the ledger to be fetched later. |
|
Btw, this work really elucidates the fees for soroban transactions which is hugely beneficial for devs! Thank you @elizabethengelman |
|
Just pushed up a change to the table, to include max fees. For a soroban tx: And for a fee bump tx: For the fee bump txns, should the inclusion fee be included in the table? Or are we okay with just the fee charged and max fee? |
|
The table presentation was very effective when all of the rows visually communicated that fees came together to make up the larger amounts (#2040 (comment)). But in the new table (#2040 (comment)), that property is lost a bit because the max fee is in the same table and its cell is the same size. Is there a way we can represent the refund maybe as a component? The refund is a first class concept. The way that it shows up in events for example in protocol 23 is that there are two events, an initial fee event charging the max fee, and then a refund fee that pays back an amount. For example, something like: |
I like it! The refunded amount is the proposed fee - the charged fee, is that correct? |
|
@leighmcculloch @janewang updated. I can also play with bolding and making text different colors as well. |
|
@elizabethengelman is this ready to go in? |
|
@elizabethengelman #2035 is merged. Could we resolve conflicts and merge this one too? |
janewang
approved these changes
Jul 9, 2025
|
@janewang conflicts have been resolved! Besides waiting for CI to finish, i think we'd also need an approval to get this merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Based on #2035
Closes #2064
Adds another command for seeing the breakdown of the transaction's fee.
stellar tx fetch fee <HASH>Why
To help with understanding and clarity around fees.
Known limitations
I'd love some feedback/ideas about the specifics of how we display the fee table.