default to testnet when no network specified #2055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds fallback behavior so that if no RPC URL, network passphrase, or network name is provided, the CLI first attempts to use the default network from the user config and otherwise defaults to the testnet. Also includes a new unit test for the testnet-default case.
- Introduce logic to read
config.defaults.networkand fall back to"testnet"when nothing is specified - Add a Tokio test to verify the default-to-testnet behavior
Comments suppressed due to low confidence (1)
cmd/soroban-cli/src/config/network.rs:473
- The test references
passphrase::TESTNETbut doesn’t import thepassphrasemodule; adduse super::super::passphrase;(or the correct path) to bring the constant into scope and prevent a compile error.
use super::super::locator;
elizabethengelman
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Solves
#2049