Add network config settings command #2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
reviewed
Jul 30, 2025
fnando
reviewed
Jul 31, 2025
|
This is ready for review again. I've changed the command to be simply 'settings'. And the command now has an |
This reverts commit 3d4c53c.
fnando
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add command to fetch network configuration settings in JSON format.
Why
A convenient way to retrieve the current network configuration for a network without needing to install, setup, and boot stellar-core.
Limitations
The command is limited to collecting settings that the CLI knows about. If it attempts to retrieve settings for a network that has a newer protocol version, then it won't be able to output all of the settings. If the command detects it is communicating with an old network it outputs a warning.