Skip to content

Fix address display. #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

Fix address display. #2102

merged 1 commit into from
Jul 31, 2025

Conversation

@fnando
Copy link
Member

@fnando fnando commented Jul 31, 2025

What

Fix address display. Even though we have the Display trait implemented, the enum debug string is being used. Using to_string() fixes it.

before
✅ Account AliasOrSecret("me") funded on "Test SDF Network ; September 2015"

after
✅ Account me funded on "Test SDF Network ; September 2015"

Why

So it's better.

Known limitations

N/A

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Jul 31, 2025
elizabethengelman
elizabethengelman approved these changes Jul 31, 2025
View reviewed changes
Copy link
Collaborator

@elizabethengelman elizabethengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@fnando fnando merged commit a947145 into main Jul 31, 2025
35 checks passed
@fnando fnando deleted the fix-display branch July 31, 2025 18:43
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elizabethengelman elizabethengelman elizabethengelman approved these changes

@leighmcculloch leighmcculloch Awaiting requested review from leighmcculloch

Assignees

No one assigned

Labels

None yet

Projects

DevX
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fnando @elizabethengelman