web/satellite: sort applications by category or name #7527
Conversation
Issue: storj#7476 Update the sorting logic to sort applications by their first category when the sort key is 'category'; otherwise, sort them by the application name. Change-Id: I41501d3516614f0e0035ff1351dc0472d470acce
|
Thank you for your pull request and welcome to our community. We require contributors to sign our new Contributor License Agreement v2, and we don't seem to have the users @prince272 on file. Once you have signed the CLA, please let us know, so we can manually review and add you to the approved contributors list. |
There was a problem hiding this comment.
Summary of Changes
Hello @prince272, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request provides a targeted fix for a bug affecting the sorting functionality on the Applications page. It refines the sorting algorithm to ensure that applications are correctly ordered based on their categories or names, improving the user experience and data presentation.
Highlights
- Bug Fix: This pull request resolves an issue where the sorting of applications by 'category' on the Applications page was not functioning correctly. It addresses Issue #7476.
- Sorting Logic Enhancement: The application sorting logic has been updated within the
filteredAppscomputed property. When thesortKeyis 'category', applications will now be sorted by their first assigned category. For all other sort keys, the sorting will default to using the application's name.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| if (aValue < bValue) return sortOrder.value === 'asc' ? -1 : 1; | ||
| if (aValue > bValue) return sortOrder.value === 'asc' ? 1 : -1; | ||
| return 0; |
There was a problem hiding this comment.
The comparison logic can be simplified by using String.prototype.localeCompare() for a more concise and idiomatic string comparison. This method is generally more robust for sorting user-visible strings as it handles international characters correctly.
const comparison = aValue.localeCompare(bValue);
return sortOrder.value === 'asc' ? comparison : -comparison;
It's as been done. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our new Contributor License Agreement v2, and we don't seem to have the users @prince272 on file. Once you have signed the CLA, please let us know, so we can manually review and add you to the approved contributors list. |
Issue: #7476
Update the sorting logic to sort applications by their first category when the sort key is 'category'; otherwise, sort them by the application name.
Change-Id: I41501d3516614f0e0035ff1351dc0472d470acce
What:
Fix sorting logic to sort applications by their first category when sortKey is 'category'; otherwise, sort by name.
Why:
Fixes broken category sorting on the Applications page (Issue #7476).
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)