test: Port away from sort and count_if #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc4057c to
a449957
Compare
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
- Coverage 97.45% 97.44% -0.01%
==========================================
Files 31 31
Lines 2276 2272 -4
==========================================
- Hits 2218 2214 -4
Misses 58 58
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sortandcount_iffunctions are only used in the unit tests and are already surrounded by code where both a device and host version of the involved data arrays are allocated. Port away from both of these functions by utilizing the host versions instead.Partially addresses #279