conn: Fix cross compilation with mingw #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingw doesn't find netinet/in.h which is not supposed to be used for a windows build. This header is conditionally compiled when _MSC_VER is not defined, however, mingw defines only _WIN32 and not the _MSC_VER. Add also _WIN32 to the condition, so mingw ignores the header and relies on winsock2.h from common.h->sock.h. Fixes #265.
sjaeckel
approved these changes
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mingw doesn't find netinet/in.h which is not supposed to be used for a windows build. This header is conditionally compiled when _MSC_VER is not defined, however, mingw defines only _WIN32 and not the _MSC_VER.
Add also _WIN32 to the condition, so mingw ignores the header and relies on winsock2.h from common.h->sock.h.
Fixes #265.