Fix ambiguous naming on Integration Tests Sniffer API (next_upstream_message vs next_downstream_message)#1236
Merged
Conversation
next_upstream_message vs next_downstream_message)
b3af780 to
46b32ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
=======================================
Coverage 19.36% 19.36%
=======================================
Files 164 164
Lines 10811 10811
=======================================
Hits 2094 2094
Misses 8717 8717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
| Branch | 1236/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot | 8,338.00 | 📈 view plot | 3,655.00 | 📈 view plot | 5,098.00 | 📈 view plot | 11.00 | 📈 view plot | 91.00 |
| get_submit | 📈 view plot | 95,156.00 | 📈 view plot | 59,255.00 | 📈 view plot | 85,071.00 | 📈 view plot | 43.00 | 📈 view plot | 282.00 |
| get_subscribe | 📈 view plot | 7,867.00 | 📈 view plot | 2,750.00 | 📈 view plot | 3,817.00 | 📈 view plot | 19.00 | 📈 view plot | 113.00 |
| serialize_authorize | 📈 view plot | 12,093.00 | 📈 view plot | 5,232.00 | 📈 view plot | 7,268.00 | 📈 view plot | 13.00 | 📈 view plot | 136.00 |
| serialize_deserialize_authorize | 📈 view plot | 24,432.00 | 📈 view plot | 9,778.00 | 📈 view plot | 13,777.00 | 📈 view plot | 38.00 | 📈 view plot | 299.00 |
| serialize_deserialize_handle_authorize | 📈 view plot | 30,201.00 | 📈 view plot | 11,981.00 | 📈 view plot | 16,936.00 | 📈 view plot | 63.00 | 📈 view plot | 370.00 |
| serialize_deserialize_handle_submit | 📈 view plot | 126,142.00 | 📈 view plot | 73,117.00 | 📈 view plot | 104,772.00 | 📈 view plot | 109.00 | 📈 view plot | 595.00 |
| serialize_deserialize_handle_subscribe | 📈 view plot | 27,745.00 | 📈 view plot | 9,569.00 | 📈 view plot | 13,510.00 | 📈 view plot | 68.00 | 📈 view plot | 397.00 |
| serialize_deserialize_submit | 📈 view plot | 114,793.00 | 📈 view plot | 67,894.00 | 📈 view plot | 97,378.00 | 📈 view plot | 60.00 | 📈 view plot | 489.00 |
| serialize_deserialize_subscribe | 📈 view plot | 23,036.00 | 📈 view plot | 8,121.00 | 📈 view plot | 11,416.00 | 📈 view plot | 42.00 | 📈 view plot | 326.00 |
| serialize_submit | 📈 view plot | 99,469.00 | 📈 view plot | 61,317.00 | 📈 view plot | 87,934.00 | 📈 view plot | 46.00 | 📈 view plot | 323.00 |
| serialize_subscribe | 📈 view plot | 11,202.00 | 📈 view plot | 4,103.00 | 📈 view plot | 5,682.00 | 📈 view plot | 19.00 | 📈 view plot | 155.00 |
Contributor
Contributor
|
| Branch | 1236/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 44.20 |
| client_sv2_handle_message_mining | 📈 view plot | 75.24 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 14.67 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 268.82 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 586.04 |
| client_sv2_open_channel | 📈 view plot | 148.52 |
| client_sv2_open_channel_serialize | 📈 view plot | 283.78 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 375.86 |
| client_sv2_setup_connection | 📈 view plot | 157.99 |
| client_sv2_setup_connection_serialize | 📈 view plot | 484.08 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 944.49 |
Contributor
|
| Branch | 1236/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 2,083.00 | 📈 view plot | 465.00 | 📈 view plot | 723.00 | 📈 view plot | 6.00 | 📈 view plot | 38.00 |
| client_sv2_handle_message_mining | 📈 view plot | 8,192.00 | 📈 view plot | 2,137.00 | 📈 view plot | 3,162.00 | 📈 view plot | 33.00 | 📈 view plot | 139.00 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 6,239.00 | 📈 view plot | 1,742.00 | 📈 view plot | 2,539.00 | 📈 view plot | 19.00 | 📈 view plot | 103.00 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 14,594.00 | 📈 view plot | 4,686.00 | 📈 view plot | 6,749.00 | 📈 view plot | 43.00 | 📈 view plot | 218.00 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 27,426.00 | 📈 view plot | 10,577.00 | 📈 view plot | 15,391.00 | 📈 view plot | 83.00 | 📈 view plot | 332.00 |
| client_sv2_open_channel | 📈 view plot | 4,291.00 | 📈 view plot | 1,453.00 | 📈 view plot | 2,151.00 | 📈 view plot | 8.00 | 📈 view plot | 60.00 |
| client_sv2_open_channel_serialize | 📈 view plot | 13,894.00 | 📈 view plot | 5,056.00 | 📈 view plot | 7,319.00 | 📈 view plot | 34.00 | 📈 view plot | 183.00 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 22,571.00 | 📈 view plot | 8,019.00 | 📈 view plot | 11,661.00 | 📈 view plot | 82.00 | 📈 view plot | 300.00 |
| client_sv2_setup_connection | 📈 view plot | 4,627.00 | 📈 view plot | 1,494.00 | 📈 view plot | 2,267.00 | 📈 view plot | 10.00 | 📈 view plot | 66.00 |
| client_sv2_setup_connection_serialize | 📈 view plot | 16,060.00 | 📈 view plot | 5,955.00 | 📈 view plot | 8,655.00 | 📈 view plot | 39.00 | 📈 view plot | 206.00 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 35,400.00 | 📈 view plot | 14,847.00 | 📈 view plot | 21,815.00 | 📈 view plot | 92.00 | 📈 view plot | 375.00 |
jbesraa
suggested changes
Oct 28, 2024
jbesraa
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Could please update the docs above the pub struct Sniffer accordingly?
46b32ca to
8186d8e
Compare
8186d8e to
19d1559
Compare
jbesraa
approved these changes
Oct 28, 2024
GitGab19
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1235