Skip to content

Duplicate tproxy MG test in integration tests#1262

Merged
GitGab19 merged 1 commit into
stratum-mining:mainfrom
jbesraa:2024-11-14-rewrite-tproxy-test
Dec 13, 2024
Merged

Duplicate tproxy MG test in integration tests#1262
GitGab19 merged 1 commit into
stratum-mining:mainfrom
jbesraa:2024-11-14-rewrite-tproxy-test

Conversation

@jbesraa

@jbesraa jbesraa commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

resolves #1208

@jbesraa jbesraa marked this pull request as ready for review November 21, 2024 10:24
@codecov

codecov Bot commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.30%. Comparing base (22da418) to head (31c52f1).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1262   +/-   ##
=======================================
  Coverage   19.30%   19.30%           
=======================================
  Files         164      164           
  Lines       10849    10849           
=======================================
  Hits         2094     2094           
  Misses       8755     8755
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.51% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.55% <ø> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branch2024-11-14-rewrite-tproxy-test
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,611.70
(-0.44%)		7,099.98
(93.12%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,357.80
(-2.11%)		8,119.40
(90.62%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,097.30
(-0.26%)		8,597.25
(94.18%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		852.30
(-1.47%)		926.64
(91.98%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		680.60
(+1.12%)		710.55
(95.78%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		248.77
(+0.12%)		269.62
(92.27%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		157.80
(+0.44%)		164.53
(95.91%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,393.00
(-0.65%)		7,078.91
(90.31%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		281.21
(+0.40%)		303.31
(92.71%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		729.99
(+0.24%)		779.16
(93.69%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		598.27
(+1.29%)		633.47
(94.44%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		206.56
(+0.32%)		217.47
(94.98%)
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branch2024-11-14-rewrite-tproxy-test
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		45.22
(+1.43%)		46.82
(96.58%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		73.74
(-3.33%)		93.78
(78.63%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.67
(+0.06%)		14.76
(99.37%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		271.80
(+2.04%)		298.88
(90.94%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		620.83
(+0.69%)		671.45
(92.46%)
client_sv2_open_channel📈 view plot
🚷 view threshold		163.78
(+1.64%)		189.75
(86.31%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		285.33
(+0.36%)		310.39
(91.93%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		401.21
(+4.29%)		417.01
(96.21%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		164.05
(+2.16%)		171.88
(95.44%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		475.16
(+1.02%)		544.54
(87.26%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		1,081.20
(+8.16%)		1,115.40
(96.93%)
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branch2024-11-14-rewrite-tproxy-test
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,372.00
(-1.02%)		8,726.00
(95.94%)		📈 view plot
🚷 view threshold		3,686.00
(-1.46%)		3,869.13
(95.27%)		📈 view plot
🚷 view threshold		5,157.00
(-1.62%)		5,450.43
(94.62%)		📈 view plot
🚷 view threshold		6.00
(-20.25%)		14.60
(41.09%)		📈 view plot
🚷 view threshold		91.00
(+0.21%)		95.72
(95.07%)
get_submit📈 view plot
🚷 view threshold		95,156.00
(-0.26%)		95,850.41
(99.28%)		📈 view plot
🚷 view threshold		59,343.00
(-0.16%)		59,712.34
(99.38%)		📈 view plot
🚷 view threshold		85,221.00
(-0.18%)		85,815.95
(99.31%)		📈 view plot
🚷 view threshold		48.00
(+8.42%)		60.08
(79.89%)		📈 view plot
🚷 view threshold		277.00
(-1.14%)		290.13
(95.48%)
get_subscribe📈 view plot
🚷 view threshold		7,857.00
(-1.93%)		8,283.03
(94.86%)		📈 view plot
🚷 view threshold		2,762.00
(-2.29%)		2,949.68
(93.64%)		📈 view plot
🚷 view threshold		3,847.00
(-2.56%)		4,144.88
(92.81%)		📈 view plot
🚷 view threshold		11.00
(-7.06%)		19.94
(55.17%)		📈 view plot
🚷 view threshold		113.00
(-1.23%)		118.59
(95.29%)
serialize_authorize📈 view plot
🚷 view threshold		12,101.00
(-1.41%)		12,567.34
(96.29%)		📈 view plot
🚷 view threshold		5,263.00
(-0.94%)		5,435.19
(96.83%)		📈 view plot
🚷 view threshold		7,326.00
(-1.07%)		7,606.65
(96.31%)		📈 view plot
🚷 view threshold		10.00
(+6.40%)		17.50
(57.16%)		📈 view plot
🚷 view threshold		135.00
(-1.99%)		142.63
(94.65%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,591.00
(-0.46%)		25,206.07
(97.56%)		📈 view plot
🚷 view threshold		9,835.00
(-0.45%)		10,037.53
(97.98%)		📈 view plot
🚷 view threshold		13,876.00
(-0.50%)		14,201.48
(97.71%)		📈 view plot
🚷 view threshold		36.00
(+3.06%)		44.86
(80.24%)		📈 view plot
🚷 view threshold		301.00
(-0.47%)		314.21
(95.80%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,073.00
(-0.83%)		30,753.57
(97.79%)		📈 view plot
🚷 view threshold		12,012.00
(-0.48%)		12,208.05
(98.39%)		📈 view plot
🚷 view threshold		16,998.00
(-0.54%)		17,311.76
(98.19%)		📈 view plot
🚷 view threshold		60.00
(+7.97%)		67.34
(89.11%)		📈 view plot
🚷 view threshold		365.00
(-1.40%)		380.81
(95.85%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,257.00
(-0.17%)		126,908.19
(99.49%)		📈 view plot
🚷 view threshold		73,200.00
(-0.10%)		73,534.05
(99.55%)		📈 view plot
🚷 view threshold		104,912.00
(-0.13%)		105,486.58
(99.46%)		📈 view plot
🚷 view threshold		111.00
(+4.79%)		125.93
(88.14%)		📈 view plot
🚷 view threshold		594.00
(-0.49%)		607.19
(97.83%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,703.00
(-0.61%)		28,536.03
(97.08%)		📈 view plot
🚷 view threshold		9,581.00
(-0.64%)		9,763.91
(98.13%)		📈 view plot
🚷 view threshold		13,533.00
(-0.76%)		13,832.40
(97.84%)		📈 view plot
🚷 view threshold		69.00
(+8.55%)		75.98
(90.81%)		📈 view plot
🚷 view threshold		395.00
(-0.68%)		414.39
(95.32%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,161.00
(-0.08%)		115,780.89
(99.46%)		📈 view plot
🚷 view threshold		68,060.00
(-0.05%)		68,414.98
(99.48%)		📈 view plot
🚷 view threshold		97,646.00
(-0.07%)		98,266.84
(99.37%)		📈 view plot
🚷 view threshold		73.00
(+15.57%)		81.41
(89.67%)		📈 view plot
🚷 view threshold		490.00
(-0.42%)		500.74
(97.86%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,135.00
(-0.68%)		23,924.15
(96.70%)		📈 view plot
🚷 view threshold		8,140.00
(-0.71%)		8,319.81
(97.84%)		📈 view plot
🚷 view threshold		11,450.00
(-0.82%)		11,739.48
(97.53%)		📈 view plot
🚷 view threshold		41.00
(+9.02%)		46.73
(87.74%)		📈 view plot
🚷 view threshold		328.00
(-0.69%)		345.56
(94.92%)
serialize_submit📈 view plot
🚷 view threshold		99,545.00
(-0.28%)		100,286.06
(99.26%)		📈 view plot
🚷 view threshold		61,405.00
(-0.14%)		61,741.18
(99.46%)		📈 view plot
🚷 view threshold		88,080.00
(-0.16%)		88,646.00
(99.36%)		📈 view plot
🚷 view threshold		53.00
(+13.52%)		64.04
(82.76%)		📈 view plot
🚷 view threshold		320.00
(-1.51%)		335.47
(95.39%)
serialize_subscribe📈 view plot
🚷 view threshold		11,302.00
(-0.90%)		11,675.36
(96.80%)		📈 view plot
🚷 view threshold		4,115.00
(-1.43%)		4,291.52
(95.89%)		📈 view plot
🚷 view threshold		5,707.00
(-1.69%)		5,997.57
(95.16%)		📈 view plot
🚷 view threshold		13.00
(+0.18%)		21.60
(60.20%)		📈 view plot
🚷 view threshold		158.00
(-0.08%)		163.74
(96.49%)
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branch2024-11-14-rewrite-tproxy-test
Testbedsv2

🚨 2 Alerts

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
client_sv2_handle_message_miningEstimated Cycles
estimated cycles		📈 plot
🚨 alert (🔔)
🚷 threshold		8,360.00
(+1.79%)		8,351.08
(100.11%)
client_sv2_mining_message_submit_standardEstimated Cycles
estimated cycles		📈 plot
🚨 alert (🔔)
🚷 threshold		6,433.00
(+2.24%)		6,431.58
(100.02%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,163.00
(+2.86%)		2,216.92
(97.57%)		📈 view plot
🚷 view threshold		473.00
(-0.08%)		488.79
(96.77%)		📈 view plot
🚷 view threshold		733.00
(-0.39%)		757.50
(96.77%)		📈 view plot
🚷 view threshold		6.00
(+16.36%)		13.16
(45.60%)		📈 view plot
🚷 view threshold		40.00
(+4.38%)		41.40
(96.62%)
client_sv2_handle_message_mining📈 view plot
🚨 view alert (🔔)
🚷 view threshold		8,360.00
(+1.79%)		8,351.08
(100.11%)		📈 view plot
🚷 view threshold		2,137.00
(-0.03%)		2,143.08
(99.72%)		📈 view plot
🚷 view threshold		3,150.00
(-0.33%)		3,171.36
(99.33%)		📈 view plot
🚷 view threshold		41.00
(+15.82%)		41.54
(98.70%)		📈 view plot
🚷 view threshold		143.00
(+2.66%)		143.09
(99.94%)
client_sv2_mining_message_submit_standard📈 view plot
🚨 view alert (🔔)
🚷 view threshold		6,433.00
(+2.24%)		6,431.58
(100.02%)		📈 view plot
🚷 view threshold		1,750.00
(-0.05%)		1,767.12
(99.03%)		📈 view plot
🚷 view threshold		2,543.00
(-0.39%)		2,575.92
(98.72%)		📈 view plot
🚷 view threshold		22.00
(+29.35%)		24.41
(90.11%)		📈 view plot
🚷 view threshold		108.00
(+3.45%)		108.25
(99.77%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,896.00
(+1.15%)		14,947.16
(99.66%)		📈 view plot
🚷 view threshold		4,694.00
(-0.02%)		4,711.12
(99.64%)		📈 view plot
🚷 view threshold		6,741.00
(-0.25%)		6,784.50
(99.36%)		📈 view plot
🚷 view threshold		56.00
(+27.00%)		57.25
(97.82%)		📈 view plot
🚷 view threshold		225.00
(+1.64%)		226.99
(99.13%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,868.00
(+1.12%)		27,928.00
(99.79%)		📈 view plot
🚷 view threshold		10,645.00
(+0.48%)		10,673.65
(99.73%)		📈 view plot
🚷 view threshold		15,498.00
(+0.51%)		15,550.67
(99.66%)		📈 view plot
🚷 view threshold		94.00
(+14.42%)		94.02
(99.98%)		📈 view plot
🚷 view threshold		340.00
(+1.45%)		341.95
(99.43%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,519.00
(+2.98%)		4,562.36
(99.05%)		📈 view plot
🚷 view threshold		1,461.00
(-0.03%)		1,476.79
(98.93%)		📈 view plot
🚷 view threshold		2,154.00
(-0.30%)		2,183.55
(98.65%)		📈 view plot
🚷 view threshold		11.00
(+30.49%)		15.37
(71.56%)		📈 view plot
🚷 view threshold		66.00
(+5.69%)		67.29
(98.08%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,154.00
(+0.91%)		14,265.28
(99.22%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,079.79
(99.69%)		📈 view plot
🚷 view threshold		7,314.00
(-0.17%)		7,350.98
(99.50%)		📈 view plot
🚷 view threshold		45.00
(+27.12%)		45.15
(99.66%)		📈 view plot
🚷 view threshold		189.00
(+1.40%)		193.28
(97.78%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,888.00
(+0.96%)		22,949.03
(99.73%)		📈 view plot
🚷 view threshold		8,040.00
(+0.15%)		8,063.52
(99.71%)		📈 view plot
🚷 view threshold		11,688.00
(+0.08%)		11,731.25
(99.63%)		📈 view plot
🚷 view threshold		84.00
(+12.39%)		86.10
(97.56%)		📈 view plot
🚷 view threshold		308.00
(+1.52%)		310.51
(99.19%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,749.00
(+1.34%)		4,783.68
(99.27%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,517.79
(98.96%)		📈 view plot
🚷 view threshold		2,274.00
(-0.19%)		2,299.32
(98.90%)		📈 view plot
🚷 view threshold		12.00
(+24.17%)		16.54
(72.53%)		📈 view plot
🚷 view threshold		69.00
(+2.34%)		70.03
(98.53%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,282.00
(+0.79%)		16,368.17
(99.47%)		📈 view plot
🚷 view threshold		5,963.00
(-0.01%)		5,978.79
(99.74%)		📈 view plot
🚷 view threshold		8,652.00
(-0.14%)		8,690.88
(99.55%)		📈 view plot
🚷 view threshold		49.00
(+22.93%)		53.18
(92.15%)		📈 view plot
🚷 view threshold		211.00
(+1.29%)		213.81
(98.69%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,782.00
(+0.60%)		35,841.73
(99.83%)		📈 view plot
🚷 view threshold		14,888.00
(+0.19%)		14,911.25
(99.84%)		📈 view plot
🚷 view threshold		21,867.00
(+0.17%)		21,917.71
(99.77%)		📈 view plot
🚷 view threshold		109.00
(+18.03%)		112.47
(96.91%)		📈 view plot
🚷 view threshold		382.00
(+0.72%)		384.90
(99.25%)
🐰 View full continuous benchmarking report in Bencher

GitGab19
GitGab19 reviewed Nov 25, 2024
View reviewed changes

@GitGab19 GitGab19 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it many times, and some of them I got this error, I don't know if you already noticed it:

running 2 tests
thread 'translation_proxy' panicked at tests-integration/tests/common/mod.rs:162:14:
called `Result::unwrap()` on an `Err` value: JsonRpc(Transport(SocketError(Os { code: 35, kind: WouldBlock, message: "Resource temporarily unavailable" })))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test translation_proxy ... FAILED
thread 'success_pool_template_provider_connection' panicked at tests-integration/tests/common/mod.rs:162:14:
called `Result::unwrap()` on an `Err` value: JsonRpc(Transport(SocketError(Os { code: 35, kind: WouldBlock, message: "Resource temporarily unavailable" })))
test success_pool_template_provider_connection ... FAILED

failures:

failures:
    success_pool_template_provider_connection
    translation_proxy

test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 37.93s

error: test failed, to rerun pass `-p integration-test --test pool_integration`

Comment thread roles/tests-integration/tests/pool_integration.rs Outdated
Comment thread roles/tests-integration/tests/common/mod.rs Outdated
plebhash
plebhash reviewed Nov 27, 2024
View reviewed changes
Comment thread roles/tests-integration/tests/pool_integration.rs Outdated
plebhash
plebhash reviewed Nov 27, 2024
View reviewed changes
Comment thread roles/tests-integration/tests/pool_integration.rs Outdated
plebhash
plebhash reviewed Nov 27, 2024
View reviewed changes
Comment thread roles/tests-integration/tests/pool_integration.rs Outdated
plebhash
plebhash reviewed Nov 27, 2024
View reviewed changes
Comment thread roles/tests-integration/tests/pool_integration.rs Outdated
plebhash added a commit to plebhash/stratum that referenced this pull request Dec 10, 2024
@plebhash
use Sniffer::wait_for_message_count on tproxy test..
72fa08f 
WARNING: this commit is just to illustrate how to unblock stratum-mining#1262

DO NOT CHERRY PICK, we still need to fix unnecessary JDC logic
@plebhash plebhash mentioned this pull request Dec 10, 2024
Closed
plebhash added a commit to plebhash/stratum that referenced this pull request Dec 10, 2024
@plebhash
use Sniffer::wait_for_message_type on tproxy test..
45542e0 
WARNING: this commit is just to illustrate how to unblock stratum-mining#1262

DO NOT CHERRY PICK, we still need to fix unnecessary JDC logic
This was referenced Dec 10, 2024
Closed
Merged
Closed
@plebhash

This comment was marked as outdated.

Sign in to view
This was referenced Dec 11, 2024
Merged
Closed
@jbesraa

jbesraa commented Dec 12, 2024

Copy link
Copy Markdown
Contributor Author

@plebhash @GitGab19 This is ready for another review. Thanks for the help here.

jbesraa
jbesraa commented Dec 12, 2024
View reviewed changes
Comment thread roles/tests-integration/tests/common/mod.rs
@GitGab19 GitGab19 merged commit 2675ef9 into stratum-mining:main Dec 13, 2024
@plebhash plebhash mentioned this pull request Dec 13, 2024
Merged
@plebhash plebhash mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitGab19 GitGab19 GitGab19 approved these changes

@plebhash plebhash plebhash approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI migration: translation-proxy MG to Integration Test

3 participants

@jbesraa @plebhash @GitGab19