Skip to content

Test Translator, JD and miner setup#1354

Merged
plebhash merged 4 commits into
stratum-mining:mainfrom
jbesraa:2025-01-16-translator-jd-test
Feb 28, 2025
Merged

Test Translator, JD and miner setup#1354
plebhash merged 4 commits into
stratum-mining:mainfrom
jbesraa:2025-01-16-translator-jd-test

Conversation

@jbesraa

@jbesraa jbesraa commented Jan 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

resolves #1353, #1474 and #1475

This is currently not working as expected. Same problem faced previously with #1207 where ghost processes are not exiting. Probably something need to be fixed at #1319/#1321

@jbesraa jbesraa mentioned this pull request Jan 16, 2025
Closed
@codecov

codecov Bot commented Jan 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.89%. Comparing base (49cfdac) to head (844fd05).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1354   +/-   ##
=======================================
  Coverage   17.89%   17.89%           
=======================================
  Files         132      132           
  Lines       10067    10067           
=======================================
  Hits         1801     1801           
  Misses       8266     8266
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_sv2-coverage 6.96% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 37.68% <ø> (ø)
codec_sv2-coverage 0.02% <ø> (ø)
common_messages_sv2-coverage 0.17% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.37% <ø> (ø)
jd_client-coverage 0.42% <ø> (ø)
jd_server-coverage 13.07% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 3.61% <ø> (ø)
mining-coverage 3.17% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.82% <ø> (ø)
noise_sv2-coverage 5.79% <ø> (ø)
pool_sv2-coverage 2.47% <ø> (ø)
protocols 23.91% <ø> (ø)
roles 6.97% <ø> (ø)
roles_logic_sv2-coverage 11.59% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.58% <ø> (ø)
utils 36.39% <ø> (ø)
v1-coverage 3.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plebhash plebhash mentioned this pull request Jan 20, 2025
Closed
@plebhash

plebhash commented Jan 29, 2025

Copy link
Copy Markdown
Member

perhaps this is also suffering from the issues reported on #1420

@jbesraa jbesraa marked this pull request as ready for review February 12, 2025 10:37
@jbesraa

jbesraa commented Feb 12, 2025

Copy link
Copy Markdown
Contributor Author

This is now unblocked after making this modification to the miner

@jbesraa jbesraa mentioned this pull request Feb 14, 2025
Merged
plebhash
plebhash reviewed Feb 26, 2025
View reviewed changes
Comment thread roles/tests-integration/tests/translator_integration.rs Outdated
plebhash
plebhash reviewed Feb 26, 2025
View reviewed changes
Comment thread test/message-generator/test/sv1-test/sv1-test.json Outdated
plebhash
plebhash reviewed Feb 26, 2025
View reviewed changes
Comment thread roles/tests-integration/tests/translator_integration.rs
plebhash
plebhash reviewed Feb 26, 2025
View reviewed changes
Comment thread roles/tests-integration/tests/translator_integration.rs
@jbesraa

jbesraa commented Feb 27, 2025

Copy link
Copy Markdown
Contributor Author

Addressed comments and rebased

This was linked to issues Feb 27, 2025
CI migration: pool-sri-test-extended_0 MG to Integration Test #1474
Closed
CI migration: pool-sri-test-extended_1 MG to Integration Test #1475
Closed
CI migration: pool-sri-test-1-standard MG to Integration Test #1476
Closed
@GitGab19

GitGab19 commented Feb 27, 2025

Copy link
Copy Markdown
Member

@jbesraa you pointed this PR to issue #1476 in the description.

But #1476 is related to standard channels, and SV2 mining device.

This PR is not covering that, can you confirm? In case, update the PR description please

@GitGab19 GitGab19 removed a link to an issue Feb 27, 2025
CI migration: pool-sri-test-1-standard MG to Integration Test #1476
Closed
@jbesraa

jbesraa commented Feb 27, 2025

Copy link
Copy Markdown
Contributor Author

@jbesraa you pointed this PR to issue #1476 in the description.

But #1476 is related to standard channels, and SV2 mining device.

This PR is not covering that, can you confirm? In case, update the PR description please

Yea that's correct. Updated desc.

@plebhash

plebhash commented Feb 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@jbesraa you pointed this PR to issue #1476 in the description.
But #1476 is related to standard channels, and SV2 mining device.
This PR is not covering that, can you confirm? In case, update the PR description please

Yea that's correct. Updated desc.

we're still removing pool-sri-test-1-standard on this PR, which should be updated too

plebhash
plebhash reviewed Feb 27, 2025
View reviewed changes
Comment thread roles/tests-integration/tests/translator_integration.rs Outdated
This was referenced Feb 27, 2025
Merged
Closed
plebhash
plebhash reviewed Feb 28, 2025
View reviewed changes
Comment thread roles/tests-integration/tests/translator_integration.rs Outdated
@jbesraa
Test Translator, JD and miner setup
51b67c7 
.. Tests that when a miner submits shares to translator it is propagated
up to the pool by JD.
plebhash
plebhash approved these changes Feb 28, 2025
View reviewed changes

@plebhash plebhash left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK but we need to fix CI

@plebhash plebhash merged commit 6dde6b9 into stratum-mining:main Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plebhash plebhash plebhash approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@jbesraa @plebhash @GitGab19