Remove benches execution from CI#1357
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1357 +/- ##
=======================================
Coverage 19.09% 19.09%
=======================================
Files 166 166
Lines 11062 11062
=======================================
Hits 2112 2112
Misses 8950 8950
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2a0a74a to
0e45821
Compare
valgrind in benchmarks workflows0e45821 to
2f219be
Compare
plebhash
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
benchesexecution from our CI.It's been two days I noticed we are getting those actions failed, with the same error reported in this recent run: https://github.com/stratum-mining/stratum/actions/runs/12828449560/job/35772517584
I don't know how many times I had to open PRs to fix stuff regarding benches during last months, and given that those benches are not complete at all, it doesn't make sense to have them as a requirement on our CI.
Maybe in the future we can improve and reintroduce them again.