Skip to content

avoid running workflows AFTER merging PRs#1373

Merged
plebhash merged 1 commit into
stratum-mining:mainfrom
plebhash:avoid-workflows-after-merging-prs
Jan 24, 2025
Merged

avoid running workflows AFTER merging PRs#1373
plebhash merged 1 commit into
stratum-mining:mainfrom
plebhash:avoid-workflows-after-merging-prs

Conversation

@plebhash

@plebhash plebhash commented Jan 21, 2025

Copy link
Copy Markdown
Member

close #1372

@plebhash plebhash added the ci/cd CI/CD label Jan 21, 2025
@codecov

codecov Bot commented Jan 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.08%. Comparing base (d96e4b0) to head (55fba7c).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1373   +/-   ##
=======================================
  Coverage   19.08%   19.08%           
=======================================
  Files         166      166           
  Lines       11066    11066           
=======================================
  Hits         2112     2112           
  Misses       8954     8954
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.55% <ø> (ø)
binary_sv2-coverage 5.34% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.28% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.44% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.44% <ø> (ø)
pool_sv2-coverage 2.04% <ø> (ø)
protocols 24.57% <ø> (ø)
roles 6.54% <ø> (ø)
roles_logic_sv2-coverage 7.93% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Shourya742
Shourya742 approved these changes Jan 22, 2025
View reviewed changes

@Shourya742 Shourya742 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

The reason why we have a check on main once the PR is merged is because we want to check if multiple changes together has caused any issue or not. But currently how are workflow works is, even if the changes on main and the PR branch are unrelated, still the github excepts us to rebase and make our PR branch consistent to main. For our workflow removing the push to main branch check is ok. But it would have been ideal if we can have merge policies a bit sorted, like unrelated change need not to be rebased or stuff.

jbesraa
jbesraa reviewed Jan 22, 2025
View reviewed changes

@jbesraa jbesraa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if you push again to this pull request, would that rerun ci?

@plebhash plebhash force-pushed the avoid-workflows-after-merging-prs branch from 5dc57ee to 24922d4 Compare January 22, 2025 12:14
@plebhash

plebhash commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

what if you push again to this pull request, would that rerun ci?

just rebased against main, CI is re-running from scratch

@plebhash

This comment was marked as outdated.

Sign in to view
@jbesraa

This comment was marked as outdated.

Sign in to view
@plebhash

plebhash commented Jan 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

marked the two comments above as outdated, as the new Github UI seems a bit buggy

IMO we should just keep rebasing PRs against main and only run CI before the PR is merged

@Shourya742

Shourya742 commented Jan 23, 2025

Copy link
Copy Markdown
Member

marked the two comments above as outdated, as the new Github UI seems a bit buggy

IMO we should just keep rebasing PRs against main and only run CI before the PR is merged

ACK.. We should be strict with it now onwards, as we are removing push on main

@plebhash plebhash force-pushed the avoid-workflows-after-merging-prs branch from 24922d4 to 55fba7c Compare January 24, 2025 13:12
@plebhash plebhash merged commit fef6142 into stratum-mining:main Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitGab19 GitGab19 GitGab19 approved these changes

@Shourya742 Shourya742 Shourya742 approved these changes

+1 more reviewer

@jbesraa jbesraa jbesraa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/cd CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

consider avoid running workflows AFTER merging PRs

4 participants

@plebhash @jbesraa @Shourya742 @GitGab19