key-utils: make it no_std with a std default feature#1398
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
- Coverage 18.06% 18.04% -0.02%
==========================================
Files 127 127
Lines 9555 9559 +4
==========================================
- Hits 1726 1725 -1
- Misses 7829 7834 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
14e4d95 to
010279d
Compare
010279d to
c8b26c8
Compare
Shourya742
requested changes
Feb 7, 2025
Shourya742
left a comment
Member
There was a problem hiding this comment.
Rest looks good, just some questions.
c8b26c8 to
de6f0d2
Compare
plebhash
approved these changes
Feb 10, 2025
de6f0d2 to
a8885ec
Compare
Shourya742
approved these changes
Feb 11, 2025
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Mar 27, 2025
as a consequence of stratum-mining#1398
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because a new
stdfeature is intriduced, the Semver MINOR should be bumped