Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.92%. Comparing base (7e09855) to head (67e63b6).
Report is 3 commits behind head on main.

@@           Coverage Diff           @@
##             main    #1603   +/-   ##
=======================================
  Coverage   21.92%   21.92%           
=======================================
  Files         135      135           
  Lines        9573     9573           
=======================================
  Hits         2099     2099           
  Misses       7474     7474           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Instead of making changes like these, we should focus on getting this merged: #1546.

#1546 is a profound change while this pr is just upgrading/aligning tokio versions. I dont see how they are related.
Also this is mentioned in the description about shared deps:

Specifying a workspace dependency is similar to package dependencies except:

1. Dependencies from this table cannot be declared as optional

2. [features](https://doc.rust-lang.org/cargo/reference/features.html) declared in this table are additive with the features from [dependencies]

Which is a deal breaker IMO.

I would not block this one because of #1546, specially when we also have #1549 and others.

#1549 #1546 and others needs further discussions and consensus before we merge them.

Instead of making changes like these, we should focus on getting this merged: #1546.

#1546 is a profound change while this pr is just upgrading/aligning tokio versions. I dont see how they are related. Also this is mentioned in the description about shared deps:

Specifying a workspace dependency is similar to package dependencies except:

1. Dependencies from this table cannot be declared as optional

2. [features](https://doc.rust-lang.org/cargo/reference/features.html) declared in this table are additive with the features from [dependencies]

Which is a deal breaker IMO.

I would not block this one because of #1546, specially when we also have #1549 and others.

#1549 #1546 and others needs further discussions and consensus before we merge them.

Moreover, currently we align shared dependencies between crates by adding them to stratum-common (see bitcoin and secp deps) so we would need to add that to the discussion as well. What I am saying here is that this PR scope is way smaller than those big changes.

Instead of making changes like these, we should focus on getting this merged: #1546.

#1546 is a profound change while this pr is just upgrading/aligning tokio versions. I dont see how they are related. Also this is mentioned in the description about shared deps:
Specifying a workspace dependency is similar to package dependencies except:

1. Dependencies from this table cannot be declared as optional

2. [features](https://doc.rust-lang.org/cargo/reference/features.html) declared in this table are additive with the features from [dependencies]

Which is a deal breaker IMO.
I would not block this one because of #1546, specially when we also have #1549 and others.
#1549 #1546 and others needs further discussions and consensus before we merge them.

Moreover, currently we align shared dependencies between crates by adding them to stratum-common (see bitcoin and secp deps) so we would need to add that to the discussion as well. What I am saying here is that this PR scope is way smaller than those big changes.

What I mean is that changes related to the unification of dependency versions are automatically resolved when any of the above-mentioned PRs get merged. Since these changes will eventually be removed within a couple of months, I don’t see the point in adding them, especially considering they are not blocking any of our current tasks.

Hey @jbesraa, your PR cannot be rebased due to conflicts. Could you resolve them, please?

Hey @jbesraa, your PR cannot be rebased due to conflicts. Could you resolve them, please?