Change SUBMIT_SOLUTION_JD to PUSH_SOLUTION#1629
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main stratum-mining/stratum#1629 +/- ##
=======================================
Coverage 21.14% 21.14%
=======================================
Files 135 135
Lines 9966 9966
=======================================
Hits 2107 2107
Misses 7859 7859
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SUBMIT_SOLUTION_JD to PUSH_SOLUTION
plebhash
reviewed
Apr 15, 2025
Closed
GitGab19
reviewed
Apr 16, 2025
plebhash
approved these changes
Apr 21, 2025
Member
|
@GitGab19 final approval? |
jbesraa
commented
Apr 29, 2025
|
|
||
| // Block propogated from JDS to TP | ||
| #[tokio::test] | ||
| async fn propogated_from_jds_to_tp() { |
Contributor
Author
There was a problem hiding this comment.
After reading stratum-mining/sv2-spec@9ddd616#diff-9c580b154d81392af22d529877e33b6680d514cb5edc755882eab2a001133fbbR56
I wonder if I should have taken that into account in this PR
Member
There was a problem hiding this comment.
yeah perhaps we should take that into the scope of #1653
but for now, we should consider every testing scenario as operating under Full-Template mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1452