Skip to content

SV2 Constants Cleanup#1667

Merged
plebhash merged 8 commits into
stratum-mining:mainfrom
jbesraa:2025-05-07/consts-refactor
May 9, 2025
Merged

SV2 Constants Cleanup#1667
plebhash merged 8 commits into
stratum-mining:mainfrom
jbesraa:2025-05-07/consts-refactor

Conversation

@jbesraa

@jbesraa jbesraa commented May 7, 2025

Copy link
Copy Markdown
Contributor

resolves #1135

@codecov

codecov Bot commented May 7, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 21.28%. Comparing base (3bc37fd) to head (afe4e97).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
protocols/v2/codec-sv2/src/decoder.rs 0.00% 8 Missing ⚠️
protocols/v2/codec-sv2/src/encoder.rs 0.00% 1 Missing ⚠️
roles/roles-utils/network-helpers/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
- Coverage   21.29%   21.28%   -0.02%     
==========================================
  Files         135      135              
  Lines        9894     9896       +2     
==========================================
- Hits         2107     2106       -1     
- Misses       7787     7790       +3     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <0.00%> (ø)
binary_sv2-coverage 10.28% <0.00%> (-0.01%) ⬇️
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 37.68% <ø> (ø)
codec_sv2-coverage 0.03% <0.00%> (-0.01%) ⬇️
common_messages_sv2-coverage 0.25% <0.00%> (-0.01%) ⬇️
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.54% <0.00%> (-0.01%) ⬇️
jd_client-coverage 0.39% <0.00%> (ø)
jd_server-coverage 12.67% <0.00%> (ø)
job_declaration_sv2-coverage 0.00% <0.00%> (ø)
key-utils-coverage 3.61% <ø> (ø)
mining-coverage 5.06% <0.00%> (-0.04%) ⬇️
mining_device-coverage 0.00% <0.00%> (ø)
mining_proxy_sv2-coverage 1.18% <0.00%> (ø)
noise_sv2-coverage 8.76% <0.00%> (-0.01%) ⬇️
pool_sv2-coverage 5.84% <0.00%> (ø)
protocols 30.90% <0.00%> (-0.05%) ⬇️
roles 11.50% <0.00%> (ø)
roles_logic_sv2-coverage 15.38% <0.00%> (-0.01%) ⬇️
sv2_ffi-coverage 0.00% <0.00%> (ø)
template_distribution_sv2-coverage 0.00% <0.00%> (ø)
translator_sv2-coverage 9.08% <0.00%> (ø)
utils 36.39% <ø> (ø)
v1-coverage 4.43% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread protocols/v2/codec-sv2/src/decoder.rs
Comment thread protocols/v2/codec-sv2/src/decoder.rs
Comment thread protocols/v2/codec-sv2/src/decoder.rs
Comment thread protocols/v2/codec-sv2/src/decoder.rs
@GitGab19 GitGab19 added the ready-to-be-merged triggers auto rebase bot label May 8, 2025
@plebhash plebhash merged commit 08c0f14 into stratum-mining:main May 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-be-merged triggers auto rebase bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: const-sv2 crate

3 participants