Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 23.40%. Comparing base (893035b) to head (6bedcd0).
Report is 15 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1728      +/-   ##
==========================================
- Coverage   23.45%   23.40%   -0.05%     
==========================================
  Files         146      146              
  Lines       10918    10940      +22     
==========================================
  Hits         2561     2561              
- Misses       8357     8379      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

IMO the approach of #1642 was suboptimal

moving the contents from const_sv2 into stratum_common was a bit redundant, since we ended up still having all constants concentrated in one single place

constants should live in the specific crates where they have contextual meaning

AFAIK, we moved all the constants to sv2-common because we were considering consolidating the imports directly from roles-logic, which in turn depends on stratum-common. However, I don't have much context on this, @GitGab19 might have more insight.

we were considering consolidating the imports directly from roles-logic

yes, I'm aware of that

this PR is still aligned with this strategy

after all, roles_logic_sv2 also depends on most crates where the constants were moved into

the only exceptions would be noise_sv2 and codec_sv2, which are imported into network_helpers_sv2

and as described in #1458, ideally the strategy of standardizing dependency exporting actually revolves around both roles_logic_sv2 and network_helpers_sv2.

LGTM, I just left a couple of comments to be reviewed before merging this.