Conversation
Member
|
thanks @coleFD it looks like there's some conflicts with can you try to resolve them? alternatively I could also do it and force-push here, if you're ok with that |
plebhash
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the channels structs manage jobs internally. This proposal decoubles job state from channels by utilizing a
JobStoretrait instead of using the job maps directly. ADefaultJobStoreis also introduced that mirrors the 1-to-1 channel-to-jobstate architecture that is currently provided.The overall goal of this proposal is to allow for more customizability (ie supporting a wider range of architectures potentially warranted by the end developer)