Skip to content

fix overlooked consequences of SetupConnection.REQUIRES_WORK_SELECTION#1826

Merged
plebhash merged 5 commits into
stratum-mining:mainfrom
plebhash:2025-08-05-overlooked-consequences-requires-work-selection
Aug 9, 2025
Merged

fix overlooked consequences of SetupConnection.REQUIRES_WORK_SELECTION#1826
plebhash merged 5 commits into
stratum-mining:mainfrom
plebhash:2025-08-05-overlooked-consequences-requires-work-selection

Conversation

@plebhash

@plebhash plebhash commented Aug 5, 2025

Copy link
Copy Markdown
Member

close #1825

@plebhash plebhash force-pushed the 2025-08-05-overlooked-consequences-requires-work-selection branch 2 times, most recently from cf06e66 to 4c789b7 Compare August 6, 2025 20:40
Comment thread protocols/v2/subprotocols/common-messages/src/setup_connection.rs
Comment thread protocols/v2/subprotocols/common-messages/src/setup_connection.rs
…v_hash even without future jobs

calling this function is still necessary to keep the channel up-to-date with regards to chain-tip, which is essential for share validation
…r::standard::StandardChannel::on_set_new_prev_hash
@plebhash plebhash force-pushed the 2025-08-05-overlooked-consequences-requires-work-selection branch from 4c789b7 to 5fb627e Compare August 8, 2025 13:49
@plebhash plebhash merged commit 60225f8 into stratum-mining:main Aug 9, 2025
11 checks passed
@plebhash plebhash deleted the 2025-08-05-overlooked-consequences-requires-work-selection branch August 9, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

overlooked consequences of SetupConnection.REQUIRES_WORK_SELECTION

3 participants