Skip to content

fix the divergence of field names in DeclareMiningJob#1856

Merged
plebhash merged 1 commit into
stratum-mining:mainfrom
lucasbalieiro:fix-declare-mining-job-field-names
Sep 5, 2025
Merged

fix the divergence of field names in DeclareMiningJob#1856
plebhash merged 1 commit into
stratum-mining:mainfrom
lucasbalieiro:fix-declare-mining-job-field-names

Conversation

@lucasbalieiro

@lucasbalieiro lucasbalieiro commented Sep 4, 2025

Copy link
Copy Markdown
Collaborator

closes #1847 ;

Changes the field name to match the specs, adjusts the comments and update where needed
This change required a new major bump

@lucasbalieiro lucasbalieiro force-pushed the fix-declare-mining-job-field-names branch 2 times, most recently from 74d3c22 to 895aa00 Compare September 4, 2025 19:39
@lucasbalieiro lucasbalieiro force-pushed the fix-declare-mining-job-field-names branch from 895aa00 to 0eb9836 Compare September 4, 2025 19:52
@lucasbalieiro lucasbalieiro marked this pull request as ready for review September 4, 2025 20:37
@plebhash plebhash merged commit d6a0a87 into stratum-mining:main Sep 5, 2025
11 checks passed
@lucasbalieiro lucasbalieiro deleted the fix-declare-mining-job-field-names branch September 5, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeclareMiningJob has wrong/misleading field names inside job_declaration_sv2

3 participants