Skip to content

revert renaming MAX_EXTRANONCE_LEN#1864

Merged
plebhash merged 1 commit into
stratum-mining:mainfrom
plebhash:2025-09-12-revert-max-extranonce-len
Sep 12, 2025
Merged

revert renaming MAX_EXTRANONCE_LEN#1864
plebhash merged 1 commit into
stratum-mining:mainfrom
plebhash:2025-09-12-revert-max-extranonce-len

Conversation

@plebhash

@plebhash plebhash commented Sep 12, 2025

Copy link
Copy Markdown
Member

reverts 3cfa510 + bd89959

starts addressing #1861

@plebhash plebhash force-pushed the 2025-09-12-revert-max-extranonce-len branch 3 times, most recently from d91909b to 73db74f Compare September 12, 2025 14:11
@plebhash

Copy link
Copy Markdown
Member Author

actually, this CI failure shows that there's no need to revert the version bump from bd89959

during #1824 we also had d79aaad, which renamed a variant of the publicly visible ExtendedExtranonceError enum, which also justifies the version bump

@plebhash plebhash changed the title revert renaming MAX_EXTRANONCE_LEN and mining_sv2 version bump revert renaming MAX_EXTRANONCE_LEN Sep 12, 2025
@plebhash plebhash merged commit c419f94 into stratum-mining:main Sep 12, 2025
11 checks passed
@plebhash plebhash deleted the 2025-09-12-revert-max-extranonce-len branch September 12, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants