channels_sv2::outputs::deserialize_outputs#1934
Merged
plebhash merged 4 commits intoOct 6, 2025
Merged
Conversation
Shourya742
reviewed
Oct 3, 2025
e898d58 to
0a0cc91
Compare
`template` module was renamed into `outputs` a `deserialize_outputs` was added to this module
…nnels_sv2::outputs::deserialize_outputs
0a0cc91 to
1116be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with new roles refactoring we're falling into a pattern of copy-pasting (and effectively duplicating) a lot of "utils" code
#1843 introduced a
jd_client::utils::deserialize_coinbase_outputsthat is now being copy-pasted into a redundantpool_sv2::utils::deserialize_coinbase_outputson #1926this PR introduces a new
channels_sv2::outputs::deserialize_outputsto avoid thisthe old
channels_sv2::templatemodule was renamed intochannels_sv2::outputs