Skip to content

refine extranonce assumptions#1944

Merged
plebhash merged 14 commits into
stratum-mining:mainfrom
plebhash:2025-10-10-extranonce-sizes
Oct 14, 2025
Merged

refine extranonce assumptions#1944
plebhash merged 14 commits into
stratum-mining:mainfrom
plebhash:2025-10-10-extranonce-sizes

Conversation

@plebhash

@plebhash plebhash commented Oct 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

close #1861

summary of changes:

  • simplified try_strip_bip141 for better maintainability
  • validation of extended shares now takes rollable_extranonce_size into consideration
  • full_extranonce_size of extended channels (both server and client sides) is always calculated based on extranonce_prefix plus rollable_extranonce_size, and no longer assumed to be MAX_EXTRANONCE_LEN
  • rollable_extranonce_size never changes across the lifespan of a channel (even after SetExtranoncePrefix)
  • JobFactory takes full_extranonce_size as a parameter on a few methods, which is used to set appropriate scriptSig_len values inside coinbase_tx_prefix
  • GroupChannel takes full_extranonce_size as a parameter on its constructor, since JobFactory now needs it
  • adapts JDC with fixed extranonce assumptions
  • adapts Pool with fixed extranonce assumptions

@plebhash plebhash force-pushed the 2025-10-10-extranonce-sizes branch from a4edd07 to 40a14f5 Compare October 13, 2025 15:51
@plebhash plebhash marked this pull request as ready for review October 13, 2025 15:52
GitGab19
GitGab19 reviewed Oct 13, 2025
View reviewed changes
Comment thread protocols/v2/channels-sv2/src/client/extended.rs Outdated
Comment thread protocols/v2/channels-sv2/src/server/extended.rs
Comment thread protocols/v2/channels-sv2/src/server/extended.rs Outdated
Comment thread roles/jd-client/src/lib/channel_manager/template_message_handler.rs
Comment thread roles/jd-client/src/lib/channel_manager/upstream_message_handler.rs
Comment thread roles/jd-client/src/lib/channel_manager/upstream_message_handler.rs
plebhash added a commit to plebhash/stratum that referenced this pull request Oct 13, 2025
@plebhash
fmt
6823db3 
CI was failing for PR stratum-mining#1944
https://github.com/stratum-mining/stratum/actions/runs/18479221948/job/52650477300?pr=1944
@plebhash plebhash force-pushed the 2025-10-10-extranonce-sizes branch from 11704ad to 6823db3 Compare October 13, 2025 22:13
@plebhash plebhash mentioned this pull request Oct 13, 2025
Closed
@plebhash plebhash force-pushed the 2025-10-10-extranonce-sizes branch 4 times, most recently from 47b4a89 to 2549a5d Compare October 14, 2025 15:05
Shourya742
Shourya742 reviewed Oct 14, 2025
View reviewed changes

@Shourya742 Shourya742 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor suggestions.

Comment thread protocols/v2/channels-sv2/src/client/extended.rs Outdated
Comment thread protocols/v2/channels-sv2/src/server/jobs/factory.rs Outdated
@plebhash plebhash mentioned this pull request Oct 28, 2025
Closed
plebhash added 13 commits October 14, 2025 15:03
@plebhash
fix bad extranonce size assumptions on channels_sv2::client::extended
54760f9
@plebhash
validate extended share extranonce size
f634809
@plebhash
fix bad extranonce size assumptions on channels_sv2::server
6d29303
@plebhash
add get_full_extranonce_size
51f1a54
@plebhash
JobFactory takes full_extranonce_size into consideration
194b364
@plebhash
channels_sv2::server::group::GroupChannel keeps full_extranonce_size …
74f80df 
…for JobFactory
@plebhash
adapt JDC to refined extranonce assumptions channel APIs
4a7c126
@plebhash
fix JDC handle_set_extranonce_prefix with correct extranonce size ass…
010f275 
…umptions
@plebhash
limit Pool's extranonce range_2 to 8 bytes
dfdc040
@plebhash
use full_extranonce_size for GroupChannel initialization
bc64aac
@plebhash
server channel constructors check for script_sig size violation
460aa4d
@plebhash
enforce extranonce_prefix size limit on server channel constructors
4f1eb48
@plebhash
add MAX_EXTRANONCE_PREFIX_LEN to channels_sv2
4020799
@plebhash plebhash force-pushed the 2025-10-10-extranonce-sizes branch from 2549a5d to 4020799 Compare October 14, 2025 18:06
@plebhash plebhash merged commit cc98bd0 into stratum-mining:main Oct 14, 2025
11 checks passed
@plebhash plebhash deleted the 2025-10-10-extranonce-sizes branch October 14, 2025 18:35
This was referenced Oct 17, 2025
Closed
Closed
@plebhash plebhash mentioned this pull request Oct 28, 2025
Closed
@plebhash plebhash mentioned this pull request Nov 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shourya742 Shourya742 Shourya742 left review comments

@GitGab19 GitGab19 GitGab19 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

need to re-evaluate strategies around extranonce sizes on channels_sv2

3 participants

@plebhash @GitGab19 @Shourya742