ci: detect companion PR changes and conditionally trigger integration tests#2026
Merged
plebhash merged 1 commit intoDec 13, 2025
Merged
Conversation
df90d1b to
cd5061c
Compare
plebhash
reviewed
Dec 12, 2025
plebhash
reviewed
Dec 12, 2025
Comment on lines
-10
to
-17
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: | ||
| - ubuntu-latest | ||
| include: | ||
| - os: ubuntu-latest | ||
| target: x86_64-unknown-linux-gnu |
Member
There was a problem hiding this comment.
are we intentionally removing these?
Collaborator
Author
There was a problem hiding this comment.
yeah, its pointless to have a matrix with just one OS.
Collaborator
Author
There was a problem hiding this comment.
Now that I’m looking at this, it makes me wonder: shouldn’t the integration tests here also run on macOS? That would actually give the matrix some real purpose, since we’d be testing across multiple OSes, similar to what we already do in sv2-apps.
Member
There was a problem hiding this comment.
Yeah I would keep testing also on macos.
Collaborator
Author
There was a problem hiding this comment.
Done, repurposed the matrix, now we run on mac and ubuntu
plebhash
reviewed
Dec 12, 2025
cd5061c to
69337f7
Compare
plebhash
approved these changes
Dec 13, 2025
c425bbb to
9309608
Compare
… tests Adds logic to parse the line "companion https://github.com/stratum-mining/sv2-apps/pull/<num>" from the PR description and expose the extracted number as COMPANION_PR_NUMBER. The workflow now re-runs integration tests only when: - the PR is opened, updated, or reopened, or - the companion line in the PR body is modified. Also updates `scripts/run-integration-tests.sh` to support a `--pr` argument which explicitly specifies the companion PR. If the flag is not provided, the script falls back to COMPANION_PR_NUMBER, and if that is unset, defaults to `main`.
9309608 to
ed12dea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2022.
This PR updates
./scripts/run-integration-tests.shand./.github/workflows/integration-tests.yamlto support the feature described in the issue #2022.From now on, whenever you open a PR in this repo and realize the changes should also be reflected in the
https://github.com/stratum-mining/sv2-appsrepo, you can simply add a line to this PR’s description.Example (as shown in the image below):
This will re-trigger the integration tests, but this time they’ll run against the specified PR in
sv2-apps.