add Group Channel adaptations on channels_sv2 + mining_sv2#2044
Merged
plebhash merged 6 commits intoJan 21, 2026
Conversation
channels_sv2channels_sv2 🎅
e31addc to
52834bc
Compare
channels_sv2 🎅channels_sv2
8194a36 to
414fd73
Compare
414fd73 to
6d14a7d
Compare
GitGab19
reviewed
Jan 5, 2026
6d14a7d to
6f0ed14
Compare
GitGab19
reviewed
Jan 6, 2026
6f0ed14 to
2af4685
Compare
GitGab19
approved these changes
Jan 6, 2026
Shourya742
approved these changes
Jan 7, 2026
Member
Author
|
even though this has 2 approvals, we should wait and only merge it in sync with stratum-mining/sv2-apps#156 |
channels_sv2channels_sv2 + mining_sv2
2af4685 to
fe76c59
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2014
companion stratum-mining/sv2-apps#156
important note: this PR is introducing a BREAKING SPEC CHANGE on
OpenExtendedMiningChannel.Successmessage, which now has an extra fieldgroup_channel_id.