Skip to content

implements the Display trait for sv1 messages#2050

Merged
Shourya742 merged 1 commit into
stratum-mining:mainfrom
lucasbalieiro:impl-display-trait-for-sv1-messages
Jan 11, 2026
Merged

implements the Display trait for sv1 messages#2050
Shourya742 merged 1 commit into
stratum-mining:mainfrom
lucasbalieiro:impl-display-trait-for-sv1-messages

Conversation

@lucasbalieiro

Copy link
Copy Markdown
Collaborator

closes #2045;

now the log showed in the issue will be presented as:

NextMiningNotify: Notify { job_id: 1, prev_hash: 562240c9f7660692ff611c16059836be9a6639ab0001c9590000000000000000, coin_base1: 02000000010000000000000000000000000000000000000000000000000000000000000000ffffffff2903a4370e00162f5374726174756d2056322053524920506f6f6c2f2f0c, coin_base2: feffffff027704a5120000000016001458806074c426bedea9376ac34685eca699f4e90f0000000000000000266a24aa21a9ed52276aaa774a9f5a24b90713467ddeaea62772299cc7138906003d6ccc0953f7a3370e00, merkle_branch: [20f5cec09db7794061cb816cc6322bb0c02752711fdb20c670d8fb3d634431ce, ..., 64f5ac53a5f9a271aa7342e6f898716a115ea62834a3c15d0dca34f5120c2dfa] (13 nodes), version: 20000000, bits: 1701ebf2, time: 6962998e, clean_jobs: true }

Also, took the chance to impl the Display trait to the other messages.

@lucasbalieiro lucasbalieiro marked this pull request as ready for review January 10, 2026 18:42

@Shourya742 Shourya742 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. One suggestion

Comment thread sv1/src/methods/client_to_server.rs
@lucasbalieiro lucasbalieiro force-pushed the impl-display-trait-for-sv1-messages branch from 9e09011 to 04e4257 Compare January 11, 2026 02:03

@Shourya742 Shourya742 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@Shourya742 Shourya742 merged commit fd45489 into stratum-mining:main Jan 11, 2026
15 checks passed
@lucasbalieiro lucasbalieiro deleted the impl-display-trait-for-sv1-messages branch January 11, 2026 11:49
This was referenced Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stratum-translation logs are too verbose/unreadable

3 participants