feat(common-messages): add has_declare_tx_data helper function#2129
Merged
plebhash merged 2 commits intoApr 30, 2026
Conversation
Shourya742
requested changes
Apr 6, 2026
Shourya742
approved these changes
Apr 27, 2026
Shourya742
left a comment
Member
There was a problem hiding this comment.
I would prefer adding it as an associated method on SetupConnection, but it looks like we would need to change a few more things here. For now, this is fine.
0840065 to
1ad5d3a
Compare
1ad5d3a to
db453f9
Compare
plebhash
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add helper function to check DECLARE_TX_DATA flag in SetupConnection.flags for Job Declaration Protocol, following the same pattern as existing helpers (has_requires_std_job, has_version_rolling, has_work_selection). Closes #2117