deprecate channels_sv2::server::jobs::job_store::JobStore#2190
Open
plebhash wants to merge 2 commits into
Open
deprecate channels_sv2::server::jobs::job_store::JobStore#2190plebhash wants to merge 2 commits into
channels_sv2::server::jobs::job_store::JobStore#2190plebhash wants to merge 2 commits into
Conversation
6a442e9 to
859beae
Compare
- make server Extended/Standard/Group concrete and internalize job store construction - remove the public JobStore trait and keep `server::jobs::job_store` crate-private with inherent methods - rename the internal store type to JobStore and update server imports, tests, rustdocs, and crate docs Rationale: - complete issue stratum-mining#2181 by removing an overengineered public abstraction while keeping a focused internal store
- switch JobStore getter signatures to return references instead of owned values - update server extended/standard/group getters and rustdocs to match borrowed access - adjust server tests to clone explicitly only when ownership is needed Rationale: - eliminate implicit cloning in hot paths and align server-side getter semantics with issue stratum-mining#2181 guidance
859beae to
7cd9430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2181
companion stratum-mining/sv2-apps#554