C++#13
Merged
Merged
Conversation
74f58cd to
5ea559c
Compare
5ea559c to
9eac18e
Compare
it's a C++ keyword
for example, variants like `Sv2Message::SetupConnection(SetupConnection)` would produce C++ with unnamed field `SetupConnection ;`
coverting these to named fields like `Sv2Message::SetupConnection { message: SetupConnection }` gives the generator a real C++ member name.
`ShareValidationError(ShareValidationError)` caused a C++ type-name collision.
to enforce compatibility with uniffi-bindgen-cpp tag v0.8.1+v0.29.4
9eac18e to
eb4ccf1
Compare
Shourya742
approved these changes
May 1, 2026
Shourya742
left a comment
Member
There was a problem hiding this comment.
The changes on rust end looks sane. I ran the example and test locally and it worked.
Member
|
One minor thing (not a blocker for this PR): the Python script doesn’t have set -euo pipefail |
Member
Author
thanks, took note of this as discussed in our sync, there's a few remaining issues on the python side I'll create a (low prio) issue with them soon, making sure to include this as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4