Add onboarding post install action type to JSON schema
#1010
Conversation
schema/stripe-app.schema.json
Outdated
| { | ||
| "const": "settings" | ||
| "oneOf": [ | ||
| { "const": "modal" }, |
There was a problem hiding this comment.
To be honest, I think it was a mistake to choose modal as one of the post_install_actions for the onboarding flow, because it doesn't explicitly imply the onboarding flow, and probably we should use "type": 'onboarding' instead:
"post_install_action": {
"type": "onboarding"
}This would abstract away the implementation details of how the Onboarding view is displayed (modal window, separate page/route, etc) in the Dashboard, and will be aligned with how the post_install_action for the Settings view is configured.
There was a problem hiding this comment.
I agree with what you said, back then we were just trying to match the action with the viewport for consistency which at the time was named "modal". We could make the change on the backend to also reflect "onboarding" instead
There was a problem hiding this comment.
I have updated the initial commit so that we define onboarding instead of modal post-install action.
Could you please re-approve?
modal post install action type to JSON schemaonboarding post install action type to JSON schema
4702e35 to
1b34eae
Compare
1b34eae to
89d4b40
Compare
Summary
Add the
onboardingpost install action type (that is used to direct users to complete onboarding tasks before using an app) to the JSON schema.