Add page module viewport ids to JSON schema #1012
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovalev-stripe
commented
Sep 29, 2025
| "stripe.dashboard.balance.overview", | ||
| "stripe.dashboard.billing.overview", | ||
| "stripe.dashboard.customer.detail", | ||
| "stripe.dashboard.customer.detail.page-module", |
There was a problem hiding this comment.
@mchu2-stripe I see that you already added stripe-app.yaml in #1011 and noticed that the YAML schema didnt have any viewports specified. Is it expected?
There was a problem hiding this comment.
yes @kovalev-stripe, that's expected. stripe-app.json and stripe-app.yaml are coexisting at the moment with all the new fields and select identifying fields (like public id and name) on the new manifest file. All the other fields not listed on stripe-app.yaml will be pulled from the existing stripe-app.json file
mchu2-stripe
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add two page module viewport ids to JSON schema.