Remove Limit, StartingAfter, and EndingBefore fields for List methods that do not accept those fields#2368
Merged
Conversation
jar-stripe
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Some Stripe V1 APIs return a list object but don't accept
limit,starting_after, orending_beforeas parameters. The Go SDK includesListParamsin every list method params struct, which makes those fields appear accessible. If a user sets them, the API returns a 400 "param not recognized" error.Affected endpoints:
GET /v1/accounts/{account}/capabilitiesGET /v1/reporting/report_typesGET /v1/reporting/payment_location_capabilities(private preview only)After this change, the params structs for these endpoints embed
Paramsinstead ofListParams, so those pagination fields simply don't exist on the type.What?
ListParamswithParamsinCapabilityListParams,PaymentLocationCapabilityListParams, andReportingReportTypeListParams. This removes theLimit,StartingAfter, andEndingBeforefields from those latter types.ListParamsto the iteration infrastructure.Changelog
Limit,StartingAfter, andEndingBeforewere embedded inCapabilityListParams,PaymentLocationCapabilityListParams, andReportingReportTypeListParamseven though they are not valid parameters and would have always resulted in a 400 from the Stripe API if set. If you were including them before in any of those 3 structs, you can safely remove them.