Skip to content

Add space between mixin#56

Merged
niklasnatter merged 3 commits into
sulu:masterfrom
alexander-schranz:feature/space-between
Apr 21, 2021
Merged

Add space between mixin#56
niklasnatter merged 3 commits into
sulu:masterfrom
alexander-schranz:feature/space-between

Conversation

@alexander-schranz

@alexander-schranz alexander-schranz commented Apr 20, 2021

Copy link
Copy Markdown
Member

Add space between component. I used a similar mixin on the sulu website that paragraphs and specific elements only have space between them but avoid that they have space outside of them like components should have to be reused inside other elements.

There I did call it _paragraphSpaces but where used on list, p, ul, ol also table tags (things inside editor). I think a more general name like spaceBetween matches it better. Open for any suggestions.

Example:

p {
    @include spaceBetween;
}

p {
     @include spaceBetween((
         default: 16px,
         mobile: 14px,
     ));
}

@alexander-schranz alexander-schranz force-pushed the feature/space-between branch 3 times, most recently from fbc88f1 to fdab852 Compare April 20, 2021 19:00
@niklasnatter

niklasnatter commented Apr 21, 2021

Copy link
Copy Markdown

Can you add an example how to use this to the PR description? 🙂

@alexander-schranz

Copy link
Copy Markdown
Member Author

@nnatter example also added to the scss file

@niklasnatter niklasnatter merged commit 885c07e into sulu:master Apr 21, 2021
@alexander-schranz alexander-schranz deleted the feature/space-between branch April 21, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants