Skip to content

Fix optional callback arities#6

Merged
sunny-g merged 2 commits into
sunny-g:masterfrom
bryanjos:fix-optional-callbacks
Mar 7, 2018
Merged

Fix optional callback arities#6
sunny-g merged 2 commits into
sunny-g:masterfrom
bryanjos:fix-optional-callbacks

Conversation

@bryanjos

@bryanjos bryanjos commented Feb 8, 2018

Copy link
Copy Markdown
Contributor

When compiling xdr in a project after getting it from hex I ran into the following error:

== Compilation error in file lib/xdr/type/base.ex ==
** (CompileError) lib/xdr/type/base.ex:1: unknown callback length/1 given as optional callback
    (stdlib) lists.erl:1263: :lists.foldl/3
    (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6
could not compile dependency :xdr, "mix compile" failed. You can recompile this dependency with "mix deps.compile xdr", update it with "mix deps.update xdr" or clean it with "mix deps.clean xdr"

I changed the arities in the optional_callback attribute to match those of the callbacks

@sunny-g

sunny-g commented Mar 7, 2018

Copy link
Copy Markdown
Owner

Thank you @bryanjos! Do you wanna bump the patch version as well so I can release a new one (not sure that the OSS best practice is here, you're my first contributor 😄)?

@bryanjos

bryanjos commented Mar 7, 2018

Copy link
Copy Markdown
Contributor Author

No problem. I've update the version to 0.1.1

@sunny-g sunny-g merged commit 8d82e72 into sunny-g:master Mar 7, 2018
@sunny-g

sunny-g commented Mar 7, 2018

Copy link
Copy Markdown
Owner

Published - thanks again @bryanjos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryanjos @sunny-g