Domain support #271
Open
Domain support #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to node 18 - fix bigint issues
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dankelleher
reviewed
Jun 27, 2023
| const output = useAddressLookup(inputValue); | ||
| const { resolvedDomain, errorMessage } = output; | ||
|
|
||
| console.log("resolved domain error", errorMessage); |
Member
There was a problem hiding this comment.
Please remove this and the commented lines below
|
|
||
| useEffect(() => { | ||
| const address = safeParsePublicKey(resolvedDomain); | ||
| console.log("address is ", address); |
| }); | ||
| } | ||
| setInputValue(addressString); | ||
| // const address = safeParsePublicKey(addressString); |
Member
There was a problem hiding this comment.
please remove if not needed
| } else return null; | ||
| }; | ||
|
|
||
| useEffect(() => { |
Member
There was a problem hiding this comment.
you can probably simplify these a little - rather than having three useEffects, you can probably just have one, which calls walletNameToAddressAndProfilePicture if the inputProp is a domain. I don't think you need to store the intermediary results walletDomainName and resolvedDomain in state hooks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: added Domain support