fix MOAB options for v5.0#521
Merged
Merged
Conversation
Contributor
|
THis looks great, I'll wait for CI to finish for the free daily test |
ljacobson64
reviewed
Jul 14, 2017
| @@ -82,8 +82,7 @@ is required. | |||
| :: | |||
Member
There was a problem hiding this comment.
Can we remove the note just above this saying that --enable-dagmc is required?
ljacobson64
reviewed
Jul 14, 2017
| @@ -98,8 +97,7 @@ configure option is required. | |||
| :: | |||
Contributor
|
that option is removed now |
Member
|
I know, which is why we shouldn't tell people it's required anymore |
Contributor
|
Oh I see, sorry, I read that as can we remove the note above the enable-dagmc part :~{ |
Member
|
so is this PR in a "good enough" state for merging. This an other PR's are beginning to get stale... |
Member
|
Just submitted a PR to Paul's branch that makes the changes I requested. |
Remove text referencing the --enable-dagmc option for MOAB
Member
|
Thanks for merging Paul. This is fine to merge after the CI passes imo |
ljacobson64
added a commit
that referenced
this pull request
Dec 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.