python3 for CI#747
Merged
Merged
Conversation
Member
Author
|
shall we upload temporary docker image to test this ? |
gonuke
reviewed
Jul 3, 2021
gonuke
left a comment
Member
There was a problem hiding this comment.
LGTM - if we can get things tested, I'll merge
| gcc \ | ||
| gfortran \ | ||
| git \ | ||
| libblas-dev \ |
Member
There was a problem hiding this comment.
Unrelated to this PR, but I don't think we need BLAS/LAPACK anymore...?
Member
Author
There was a problem hiding this comment.
I forgot about this, issuing a news PR for it !
(maybe it could be a good test for our docker building/testing PR)
Member
Author
|
@gonuke it is building against the newly pushed image (repushed 15 minutes ago) this should be redo when CI passes |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating docker file to use python3.
it is probably time we retire python2