improve path pattern to trigger docker build workflow#772
Merged
gonuke merged 2 commits intosvalinn:developfrom Jul 23, 2021
Merged
improve path pattern to trigger docker build workflow#772gonuke merged 2 commits intosvalinn:developfrom
gonuke merged 2 commits intosvalinn:developfrom
Conversation
Member
|
needs a rebase... Did you cancel the build's for a reason - or do we just have to assume it will work since this PR will always trigger a build anyway? |
Member
Author
|
I did cancelled it because nothing but the trigger of the workflow changed. this one triggering the build workflow is expected as we modified |
Member
|
Thanks @bam241 - we'll keep an eye on this with future PR's to see that it's behaving as expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should left out all the pieces we used for building and testing