Attempt to ensure we are using python3 for amalgamation#773
Merged
Conversation
gonuke
reviewed
Jul 23, 2021
| * Including installation of a CMake version file for use with `find_package` in client codes. (#722) | ||
| * CMake option to checkout PyNE submodule automatically (#734) | ||
| * GitHub Action to build and upload Docker images. (#746, #748, #754, #757, #758, #759, #765, #767) | ||
| * Ensuring Python3 is present and enforcing it for PyNE amalgamation |
Member
There was a problem hiding this comment.
please
Suggested change
| * Ensuring Python3 is present and enforcing it for PyNE amalgamation | |
| * Ensuring Python3 is present and enforcing it for PyNE amalgamation (#773) |
Member
Author
|
sadly the find_package method did not work as it requires cmake 3.12 min.... I was not ready to bump our cmake requirement.... |
Member
|
This passes tests... does it do what you need? |
Member
Author
|
I need to check in Cubit-plugin where we have problem with pyne amalgamation, I'll ping you when I know more |
Member
Author
|
@gonuke it worked as intended see: svalinn/Cubit-plugin#107 I am happy with those changes |
Member
|
Thanks @bam241 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempt to enforce python3 usage when amalgamating PyNE