Skip to content

Mac ci#780

Merged
gonuke merged 36 commits into
svalinn:developfrom
bam241:mac_CI
Aug 22, 2021
Merged

Mac ci#780
gonuke merged 36 commits into
svalinn:developfrom
bam241:mac_CI

Conversation

@bam241

@bam241 bam241 commented Aug 20, 2021

Copy link
Copy Markdown
Member

first attempt to setup MACOS CI

@gonuke

gonuke commented Aug 21, 2021

Copy link
Copy Markdown
Member

Maybe start with the build strategy in the condo-forge Moab-feedstock? (Just a thought)

@gonuke gonuke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out @bam241 - a little change for consitency

Comment thread .github/workflows/mac_build_test.yml Outdated
bam241 and others added 2 commits August 22, 2021 16:02
@bam241 bam241 marked this pull request as ready for review August 22, 2021 14:09
@gonuke

gonuke commented Aug 22, 2021

Copy link
Copy Markdown
Member

Thanks for the quick work here @bam241. I'm merging this first because the rebase will probably be simpler this way around

@gonuke gonuke merged commit 7bc70a1 into svalinn:develop Aug 22, 2021
@pshriwise

pshriwise commented Aug 22, 2021

Copy link
Copy Markdown
Member

Thanks for tracking down the cause of the problem here @bam241! Sorry for not including that header initially.

@bam241 bam241 deleted the mac_CI branch November 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants