More stable package find instructions#878
Merged
gonuke merged 3 commits intosvalinn:developfrom Apr 17, 2023
Merged
Conversation
Member
|
Thanks @ebknudsen - this seems reasonable to me. I suppose we should be testing with DD at some point in our process - perhaps at merge time, even if not during PR review. Thoughts @pshriwise ? |
Member
|
Yes, I agree. I thought we were at some point. Did that go away? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow these guidelines when making a Pull Request.
This template was adapted from here and here.
Description
Stabililize the search routines for MOAB and double-down
Motivation and Context
Changes
Bug-fix
Behavior
Old behaviour: can cause installation to fail.
New behaviour: more stable installation, less dependent on local cmake parameters.