Fix docker args#896
Merged
Merged
Conversation
Member
Author
|
Success of this build is demonstrated here. |
pshriwise
reviewed
Aug 16, 2023
50d400e to
6bb5326
Compare
Member
Author
|
New test of the docker building underway here. |
Member
Author
It appears to have been successful! |
shimwell
approved these changes
Aug 17, 2023
shimwell
left a comment
Member
There was a problem hiding this comment.
This looks good to me, Paul has put in a nice python command to fix the hdf5 versions / major version error.
@pshriwise is this one ok to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass correctly named docker arguments to manage builds.
Also streamlines the docker build & test further taking more advantage of the multi-stage-build action.
Motivation and Context
We currently build multiple docker images with a matrix of options. The variable names to control the HDF5 and MOAB versions were not named correctly. This did not create a flaw in our building/testing, because we only attempted a single version of each and those versions were the defaults anyway. This PR corrects that.
Changes
Rename the build args passed to Docker & combine two steps in the workflow.